ZOOKEEPER-2858. Disable reverse DNS lookup for java client #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anmolnar , to me the patch looks good and provides effective mitigation 👍🏼 |
Contributor
Author
|
@eolivelli @kezhuw please review. |
kezhuw
approved these changes
Oct 3, 2025
Member
kezhuw
left a comment
kezhuw
left a comment
There was a problem hiding this comment.
Shall we create a dedicated jira for this ? ZOOKEEPER-2858 talked about sasl part.
Contributor
Author
Oh, my bad sorry. Let me create a separate Jira ticket and update pull request. |
Contributor
Author
Contributor
Author
|
@onmywaytoheaven Please move your review to the new pull request: #2325 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the same property that was implemented in Apache HBase for the same purpose.
Disable reverse DNS lookups by default for both quorum and client protocols to be consistent. This should be safe from backward compatibility perspective in a new major (minor?) version if we cut 4.0.0 from master soon. In a
branch-3.9backport we should enable reverse lookup in the quorum protocol by default to support smooth transition.